chore: handle exceeding maximum inputs when funding a transaction #2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvares
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10,
danielbate,
nedsalk,
petertonysmith94 and
maschad
as code owners
Torres-ssf
requested changes
Jul 23, 2024
There was a problem hiding this comment.
@mvares Nice work on this 👍 and thanks again for helping us.
I've left some suggestions
Torres-ssf
requested changes
Jul 23, 2024
I'm working on this. How could we simulate more than 250 inputs? |
|
Aditionally, the tests of CI are falling after the changes. cc @Torres-ssf |
Torres-ssf
requested changes
Jul 25, 2024
|
TY, @Torres-ssf! Currently, I'm considering to mock |
danielbate
reviewed
Jul 26, 2024
nedsalk
reviewed
Jul 29, 2024
mvares
force-pushed
the
mv/chore/max-input
branch
from
b31faeb to
6e2337d
Compare
Torres-ssf
previously approved these changes
Aug 6, 2024
Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>
|
|
nedsalk
approved these changes
Aug 6, 2024
Torres-ssf
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
In this release, we:
Summary
Enforces a maximum limit of 255 inputs for
fundinga transaction. If this limit isexceeded, anerroris triggered to prevent processing.Checklist
teststo prove my changesdocs